Fix cloudflare workers-types usage #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use devDependencies for types and optionally peerDependencies Otherwise, this will mess up any app or library that uses cloudflare's auto-generated workers types
Member
|
Hi @bastiankistner, thanks for bringing this to our attention 🙌 Moving the package to peer dependencies makes sense to me, and seems like a good approach to ensuring compatibility. I'm hoping to merge the peer dependency update and release a new version of our package as soon as possible 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use devDependencies for types and optionally peerDependencies Otherwise, this will mess up any app or library that uses cloudflare's auto-generated workers types
Cloudflare allows generating types with
wrangler types. If we have@cloudflare/workers-typesin ourdependenciesthis will conflict with theEnvdeclaration. Therefore this package must be used as apeerDependencyand can still be used for development as adevDependency. This avoids the conflict when using this package.I published a temporary package as
logtail-edge-cfon npm that I will be using until this PR is merged.